Don’t lint SCSS files that have come from outside

We should (and do) keep exact copies of SCSS files that have come from
elsewhere so that we can easily upgrade them. But sometimes they don’t
always pass our linting rules, or throw a lot of warnings, which is
noisy.

This commit:
- moves such files into their own subdirectory
- tells SCSS Lint to ignore files in this directory
This commit is contained in:
Chris Hill-Scott
2016-04-13 12:50:13 +01:00
parent 9acd344475
commit b549b98108
7 changed files with 16 additions and 6 deletions

View File

@@ -1,3 +1,7 @@
.column-whole {
@include grid-column(1/1);
}
.column-three-quarters {
@include grid-column(3/4);
}

View File

@@ -121,7 +121,7 @@ td {
margin-bottom: 5px;
}
a[rel="external"] {
a[rel='external'] {
@include external-link-default;
@include external-link-16;
@include media(tablet) {

View File

@@ -113,7 +113,7 @@
margin-bottom: $gutter;
&:last-child {
margin-bottom: 0
margin-bottom: 0;
}
& + p {

View File

@@ -1,3 +1,5 @@
$white-50-opaque: rgba($white, 0.5);
.email-message {
margin-bottom: $gutter;
@@ -76,9 +78,9 @@
color: $white;
border-style: solid;
border-width: 3px;
border-colour: $white;
border-color: $white;
border-radius: 6px;
box-shadow: 0 0 0 1px rgba($white, 0.5);
box-shadow: 0 0 0 1px $white-50-opaque;
&:hover {
background: $link-hover-colour;

View File

@@ -47,7 +47,7 @@ $path: '/static/images/';
@import 'components/browse-list';
@import 'components/email-message';
@import 'components/api-key';
@import 'components/previous-next-navigation';
@import 'components/vendor/previous-next-navigation';
@import 'views/job';
@import 'views/edit-template';

View File

@@ -108,7 +108,11 @@ gulp.task('watchForChanges', function() {
});
gulp.task('lint:sass', () => gulp
.src(paths.src + 'stylesheets/**/*.scss')
.src([
paths.src + 'stylesheets/*.scss',
paths.src + 'stylesheets/components/*.scss',
paths.src + 'stylesheets/views/*.scss',
])
.pipe(plugins.sassLint())
.pipe(plugins.sassLint.format(stylish))
.pipe(plugins.sassLint.failOnError())