darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop writing job metadata to the session

Browse Source 
We’re not looking at the job metadata in the session any more (see
previous commits) so it’s safe to stop writing it.
This commit is contained in:
Chris Hill-Scott
2018-04-30 12:10:54 +01:00
parent 8c04f8f21a
commit b44074bf3a
2 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/app/main/views/test_send.py
View File

@@ -382,7 +382,7 @@ def test_upload_csvfile_with_errors_shows_check_page_with_errors(
)
with logged_in_client.session_transaction() as session:
assert session['file_uploads'] == {}
assert 'file_uploads' not in session
assert response.status_code == 200
content = response.get_data(as_text=True)
@@ -501,7 +501,7 @@ def test_upload_csvfile_with_missing_columns_shows_error(
)
with client_request.session_transaction() as session:
assert session['file_uploads'] == {}
assert 'file_uploads' not in session
assert normalize_spaces(page.select('.banner-dangerous')[0].text) == expected_error
@@ -1537,11 +1537,8 @@ def test_upload_csvfile_with_valid_phone_shows_all_numbers(
content_type='multipart/form-data',
follow_redirects=True
)
with logged_in_client.session_transaction() as sess:
assert 'original_file_name' not in sess['file_uploads'][fake_uuid]
assert sess['file_uploads'][fake_uuid]['notification_count'] == 53
assert sess['file_uploads'][fake_uuid]['template_id'] == fake_uuid
assert sess['file_uploads'][fake_uuid]['valid'] is True
with logged_in_client.session_transaction() as session:
assert 'file_uploads' not in session
mock_s3_set_metadata.assert_called_once_with(
SERVICE_ONE_ID,