diff --git a/app/main/views/send.py b/app/main/views/send.py index 7354b9de6..19b3c5a84 100644 --- a/app/main/views/send.py +++ b/app/main/views/send.py @@ -542,14 +542,7 @@ def _check_messages(service_id, template_id, upload_id, preview_row, letters_as_ elif preview_row > 2: abort(404) - if 'file_uploads' not in session: - session['file_uploads'] = {} - session['file_uploads'][upload_id] = {} - if any(recipients) and not recipients.has_errors: - session['file_uploads'][upload_id]['notification_count'] = len(recipients) - session['file_uploads'][upload_id]['template_id'] = str(template_id) - session['file_uploads'][upload_id]['valid'] = True set_metadata_on_csv_upload( service_id, upload_id, @@ -561,8 +554,6 @@ def _check_messages(service_id, template_id, upload_id, preview_row, letters_as_ 1600, ), ) - else: - session['file_uploads'].pop(upload_id) return dict( recipients=recipients, diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py index 707a2d220..bfdbdc194 100644 --- a/tests/app/main/views/test_send.py +++ b/tests/app/main/views/test_send.py @@ -382,7 +382,7 @@ def test_upload_csvfile_with_errors_shows_check_page_with_errors( ) with logged_in_client.session_transaction() as session: - assert session['file_uploads'] == {} + assert 'file_uploads' not in session assert response.status_code == 200 content = response.get_data(as_text=True) @@ -501,7 +501,7 @@ def test_upload_csvfile_with_missing_columns_shows_error( ) with client_request.session_transaction() as session: - assert session['file_uploads'] == {} + assert 'file_uploads' not in session assert normalize_spaces(page.select('.banner-dangerous')[0].text) == expected_error @@ -1537,11 +1537,8 @@ def test_upload_csvfile_with_valid_phone_shows_all_numbers( content_type='multipart/form-data', follow_redirects=True ) - with logged_in_client.session_transaction() as sess: - assert 'original_file_name' not in sess['file_uploads'][fake_uuid] - assert sess['file_uploads'][fake_uuid]['notification_count'] == 53 - assert sess['file_uploads'][fake_uuid]['template_id'] == fake_uuid - assert sess['file_uploads'][fake_uuid]['valid'] is True + with logged_in_client.session_transaction() as session: + assert 'file_uploads' not in session mock_s3_set_metadata.assert_called_once_with( SERVICE_ONE_ID,