darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change ‘title’ to ‘reference’ when writing alert

Browse Source 
On the screen where you write an alert without a template Andy pointed
out that ‘title’ feels  bit out of place.

We chose this because ‘Template name’ definitely didn’t fit, but I agree
that reference is better.

Via https://trello.com/c/EqUln5yD/60-changing-title-to-reference-for-alert-template-new-message
This commit is contained in:
Chris Hill-Scott
2021-10-18 15:43:01 +01:00
parent 66e5022198
commit af7a0a52ab
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/broadcast/write-new-broadcast.html
View File

@@ -24,7 +24,7 @@
{{ form.name(param_extensions={ {{ form.name(param_extensions={
"classes": "govuk-!-width-full", "classes": "govuk-!-width-full",
"hint": {"text": "Your recipients will not see this"}, "hint": {"text": "Your recipients will not see this"},
"label": {"text": "Title"} "label": {"text": "Reference"}
}) }} }) }}
{{ textbox( {{ textbox(
form.template_content, form.template_content,

2
tests/app/main/views/test_broadcast.py
View File

@@ -712,8 +712,10 @@ def test_write_new_broadcast_page(
assert form['method'] == 'post' assert form['method'] == 'post'
assert 'action' not in form assert 'action' not in form
assert normalize_spaces(page.select_one('label[for=name]').text) == 'Reference'
assert page.select_one('input[type=text]')['name'] == 'name' assert page.select_one('input[type=text]')['name'] == 'name'
assert normalize_spaces(page.select_one('label[for=template_content]').text) == 'Message'
assert page.select_one('textarea')['name'] == 'template_content' assert page.select_one('textarea')['name'] == 'template_content'
assert page.select_one('textarea')['data-module'] == 'enhanced-textbox' assert page.select_one('textarea')['data-module'] == 'enhanced-textbox'
assert page.select_one('textarea')['data-highlight-placeholders'] == 'false' assert page.select_one('textarea')['data-highlight-placeholders'] == 'false'