From af7a0a52abcfecd3a40fdeac6ad762a7981b2990 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 18 Oct 2021 15:43:01 +0100 Subject: [PATCH] =?UTF-8?q?Change=20=E2=80=98title=E2=80=99=20to=20?= =?UTF-8?q?=E2=80=98reference=E2=80=99=20when=20writing=20alert?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On the screen where you write an alert without a template Andy pointed out that ‘title’ feels bit out of place. We chose this because ‘Template name’ definitely didn’t fit, but I agree that reference is better. Via https://trello.com/c/EqUln5yD/60-changing-title-to-reference-for-alert-template-new-message --- app/templates/views/broadcast/write-new-broadcast.html | 2 +- tests/app/main/views/test_broadcast.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/templates/views/broadcast/write-new-broadcast.html b/app/templates/views/broadcast/write-new-broadcast.html index 4419c0766..ab7457115 100644 --- a/app/templates/views/broadcast/write-new-broadcast.html +++ b/app/templates/views/broadcast/write-new-broadcast.html @@ -24,7 +24,7 @@ {{ form.name(param_extensions={ "classes": "govuk-!-width-full", "hint": {"text": "Your recipients will not see this"}, - "label": {"text": "Title"} + "label": {"text": "Reference"} }) }} {{ textbox( form.template_content, diff --git a/tests/app/main/views/test_broadcast.py b/tests/app/main/views/test_broadcast.py index 3c13b281c..35cb84053 100644 --- a/tests/app/main/views/test_broadcast.py +++ b/tests/app/main/views/test_broadcast.py @@ -712,8 +712,10 @@ def test_write_new_broadcast_page( assert form['method'] == 'post' assert 'action' not in form + assert normalize_spaces(page.select_one('label[for=name]').text) == 'Reference' assert page.select_one('input[type=text]')['name'] == 'name' + assert normalize_spaces(page.select_one('label[for=template_content]').text) == 'Message' assert page.select_one('textarea')['name'] == 'template_content' assert page.select_one('textarea')['data-module'] == 'enhanced-textbox' assert page.select_one('textarea')['data-highlight-placeholders'] == 'false'