Merge pull request #3364 from alphagov/quis-patch-1

Show uploads link even without letters permission

app/templates/main_nav.html

@@ -9,9 +9,7 @@
     {% endif %}
     <li><a class="govuk-link govuk-link--no-visited-state{{ main_navigation.is_selected('templates') }}" href="{{ url_for('.choose_template', service_id=current_service.id) }}">Templates</a></li>
     {% if current_user.has_permissions('view_activity') %}
-      {% if current_service.can_upload_letters %}
-        <li><a class="govuk-link govuk-link--no-visited-state{{ main_navigation.is_selected('uploads') }}" href="{{ url_for('main.uploads', service_id=current_service.id) }}">Uploads</a></li>
-      {% endif %}
+      <li><a class="govuk-link govuk-link--no-visited-state{{ main_navigation.is_selected('uploads') }}" href="{{ url_for('main.uploads', service_id=current_service.id) }}">Uploads</a></li>
     {% else %}
       <li><a class="govuk-link govuk-link--no-visited-state{{ casework_navigation.is_selected('sent-messages') }}" href="{{ url_for('.view_notifications', service_id=current_service.id, status='sending,delivered,failed') }}">Sent messages</a></li>
       {% if current_service.has_jobs or current_service.can_upload_letters %}

tests/app/main/views/accounts/test_choose_accounts.py

@@ -271,6 +271,7 @@ def test_should_show_back_to_service_if_user_belongs_to_service(
         ''
         'Dashboard '
         'Templates '
+        'Uploads '
         'Team members'
     )
 

tests/app/test_navigation.py

@@ -169,6 +169,7 @@ def test_navigation_urls(
     ] == [
         '/services/{}'.format(SERVICE_ONE_ID),
         '/services/{}/templates'.format(SERVICE_ONE_ID),
+        '/services/{}/uploads'.format(SERVICE_ONE_ID),
         '/services/{}/users'.format(SERVICE_ONE_ID),
         '/services/{}/usage'.format(SERVICE_ONE_ID),
         '/services/{}/service-settings'.format(SERVICE_ONE_ID),