darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1347 from alphagov/dict-key-conflict

Browse Source 
Mutate dictionary instead of creating new one
This commit is contained in:
Chris Hill-Scott
2017-06-30 15:20:45 +01:00
committed by GitHub
parent 0b296ed8de ef567210ff
commit 9bdc1bebfe
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/main/views/notifications.py
View File

@@ -115,16 +115,9 @@ def get_all_personalisation_from_notification(notification):
notification['personalisation'] = {} notification['personalisation'] = {}
if notification['template']['template_type'] == 'email': if notification['template']['template_type'] == 'email':
return dict( notification['personalisation']['email_address'] = notification['to']
email_address=notification['to'],
**notification['personalisation']
)
if notification['template']['template_type'] == 'sms': if notification['template']['template_type'] == 'sms':
return dict( notification['personalisation']['phone_number'] = notification['to']
phone_number=notification['to'],
**notification['personalisation']
)
if notification['template']['template_type'] == 'letter': return notification['personalisation']
return notification['personalisation']