darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 06:18:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Added missing environment variables for the server process

Browse Source 
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
This commit is contained in:
Carlo Costino
2024-01-04 17:42:54 -05:00
parent c652c17617
commit 997aa8e72f
3 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/checks.yml vendored
View File

@@ -116,6 +116,9 @@ jobs:
run: make run-flask & run: make run-flask &
env: env:
NOTIFY_ENVIRONMENT: development NOTIFY_ENVIRONMENT: development
NOTIFY_E2E_AUTH_STATE_PATH: ${{ secrets.NOTIFY_E2E_AUTH_STATE_PATH }}
NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}
- name: Run E2E tests - name: Run E2E tests
run: poetry run pytest -v --browser chromium --browser firefox --browser webkit tests/end_to_end run: poetry run pytest -v --browser chromium --browser firefox --browser webkit tests/end_to_end
# Debugging for now to troubleshoot a connectivity issue to the local servers # Debugging for now to troubleshoot a connectivity issue to the local servers

11
tests/conftest.py
View File

@@ -3576,12 +3576,11 @@ def login_for_end_to_end_testing(browser):
# page.wait_for_load_state('domcontentloaded') # page.wait_for_load_state('domcontentloaded')
# # Save storage state into the file. # Save storage state into the file.
# auth_state_path = os.path.join( auth_state_path = os.path.join(
# os.getenv('NOTIFY_E2E_AUTH_STATE_PATH'), os.getenv("NOTIFY_E2E_AUTH_STATE_PATH"), "state.json"
# 'state.json' )
# ) context.storage_state(path=auth_state_path)
# context.storage_state(path=auth_state_path)
@pytest.fixture(scope="session") @pytest.fixture(scope="session")

5
tests/end_to_end/test_accounts_page.py
View File

@@ -28,11 +28,6 @@ def test_add_new_service_workflow(end_to_end_context):
page = _bypass_sign_in(end_to_end_context) page = _bypass_sign_in(end_to_end_context)
page.goto(f"{E2E_TEST_URI}/") page.goto(f"{E2E_TEST_URI}/")
# sign_in_button = page.get_by_role("link", name="Sign in")
#
# Test trying to sign in. Because we are loading the email and password
# sign_in_button.click()
#
# Wait for the next page to fully load. # Wait for the next page to fully load.
page.wait_for_load_state("domcontentloaded") page.wait_for_load_state("domcontentloaded")