From 997aa8e72f0d93f7a0c81c4241f9d8e3a04928df Mon Sep 17 00:00:00 2001 From: Carlo Costino Date: Thu, 4 Jan 2024 17:42:54 -0500 Subject: [PATCH] Added missing environment variables for the server process Signed-off-by: Carlo Costino --- .github/workflows/checks.yml | 3 +++ tests/conftest.py | 11 +++++------ tests/end_to_end/test_accounts_page.py | 5 ----- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 9dfd779d4..498a9f273 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -116,6 +116,9 @@ jobs: run: make run-flask & env: NOTIFY_ENVIRONMENT: development + NOTIFY_E2E_AUTH_STATE_PATH: ${{ secrets.NOTIFY_E2E_AUTH_STATE_PATH }} + NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }} + NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }} - name: Run E2E tests run: poetry run pytest -v --browser chromium --browser firefox --browser webkit tests/end_to_end # Debugging for now to troubleshoot a connectivity issue to the local servers diff --git a/tests/conftest.py b/tests/conftest.py index 48ea3c5fa..269bf5282 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -3576,12 +3576,11 @@ def login_for_end_to_end_testing(browser): # page.wait_for_load_state('domcontentloaded') - # # Save storage state into the file. - # auth_state_path = os.path.join( - # os.getenv('NOTIFY_E2E_AUTH_STATE_PATH'), - # 'state.json' - # ) - # context.storage_state(path=auth_state_path) + # Save storage state into the file. + auth_state_path = os.path.join( + os.getenv("NOTIFY_E2E_AUTH_STATE_PATH"), "state.json" + ) + context.storage_state(path=auth_state_path) @pytest.fixture(scope="session") diff --git a/tests/end_to_end/test_accounts_page.py b/tests/end_to_end/test_accounts_page.py index 070e5d08d..498242743 100644 --- a/tests/end_to_end/test_accounts_page.py +++ b/tests/end_to_end/test_accounts_page.py @@ -28,11 +28,6 @@ def test_add_new_service_workflow(end_to_end_context): page = _bypass_sign_in(end_to_end_context) page.goto(f"{E2E_TEST_URI}/") - # sign_in_button = page.get_by_role("link", name="Sign in") - # - # Test trying to sign in. Because we are loading the email and password - # sign_in_button.click() - # # Wait for the next page to fully load. page.wait_for_load_state("domcontentloaded")