darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-05 14:48:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add line to template page if you can’t do anything

Browse Source 
If someone has no permissions but needs permissions the thing they’re
probably going to need is to send a message or edit a template.

The place they will probably come to is the place where the buttons
would be – users with these permissions are finding the thing they need
to do on this page.

So this commit adds a line to this page which (hopefully) makes it clear
they’re in the right place, but need to go and speak to someone.
This commit is contained in:
Chris Hill-Scott
2018-03-12 15:46:54 +00:00
parent 4b929aaa6c
commit 9838c3908b
3 changed files with 32 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/main/views/test_templates.py
View File

@@ -110,22 +110,31 @@ def test_should_show_page_for_one_template(
mock_get_service_template.assert_called_with(service_one['id'], template_id)
@pytest.mark.parametrize('permissions, links_to_be_shown', [
@pytest.mark.parametrize('permissions, links_to_be_shown, permissions_warning_to_be_shown', [
(
['view_activity'],
[]
[],
'If you need to send this text message or edit this template, contact your manager.'
),
(
['manage_api_keys'],
[],
None,
),
(
['manage_templates'],
['.edit_service_template']
['.edit_service_template'],
None,
),
(
['send_messages'],
['.send_messages', '.set_sender']
['.send_messages', '.set_sender'],
None,
),
(
['send_messages', 'manage_templates'],
['.send_messages', '.set_sender', '.edit_service_template']
['.send_messages', '.set_sender', '.edit_service_template'],
None,
),
])
def test_should_be_able_to_view_a_template_with_links(
@@ -138,6 +147,7 @@ def test_should_be_able_to_view_a_template_with_links(
fake_uuid,
permissions,
links_to_be_shown,
permissions_warning_to_be_shown,
):
active_user_with_permissions._permissions[service_one['id']] = permissions + ['view_activity']
client.login(active_user_with_permissions, mocker, service_one)
@@ -161,6 +171,10 @@ def test_should_be_able_to_view_a_template_with_links(
template_id=fake_uuid,
)
assert normalize_spaces(page.select_one('main p').text) == (
permissions_warning_to_be_shown or 'To: phone number'
)
def test_should_show_template_id_on_template_page(
logged_in_client,