darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 09:19:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

Updated msg for the failed login.

Browse Source
This commit is contained in:
Nicholas Staples
2016-04-26 12:14:06 +01:00
parent 3122500ce0
commit 9225c0813c
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/main/views/sign_in.py
View File

@@ -5,7 +5,8 @@ from flask import (
session, session,
flash, flash,
request, request,
abort abort,
Markup
) )
from flask.ext.login import ( from flask.ext.login import (
@@ -69,7 +70,11 @@ def sign_in():
else: else:
return redirect(url_for('.two_factor')) return redirect(url_for('.two_factor'))
# Vague error message for login in case of user not known, locked, inactive or password not verified # Vague error message for login in case of user not known, locked, inactive or password not verified
flash('Username or password is incorrect') flash(Markup((
"The username or password you entered is incorrect.<br/>"
" If you need to, you can <a href={password_reset}>reset "
"your password</a>").format(password_reset=url_for('.forgot_password'))
))
return render_template('views/signin.html', form=form) return render_template('views/signin.html', form=form)

4
tests/app/main/views/test_sign_in.py
View File

@@ -51,7 +51,7 @@ def test_should_return_locked_out_true_when_user_is_locked(app_,
'email_address': 'valid@example.gov.uk', 'email_address': 'valid@example.gov.uk',
'password': 'whatIsMyPassword!'}) 'password': 'whatIsMyPassword!'})
assert resp.status_code == 200 assert resp.status_code == 200
assert 'Username or password is incorrect' in resp.get_data(as_text=True) assert 'The username or password you entered is incorrect' in resp.get_data(as_text=True)
def test_should_return_200_when_user_does_not_exist(app_, mock_get_user_by_email_not_found): def test_should_return_200_when_user_does_not_exist(app_, mock_get_user_by_email_not_found):
@@ -61,7 +61,7 @@ def test_should_return_200_when_user_does_not_exist(app_, mock_get_user_by_email
'email_address': 'notfound@gov.uk', 'email_address': 'notfound@gov.uk',
'password': 'doesNotExist!'}) 'password': 'doesNotExist!'})
assert response.status_code == 200 assert response.status_code == 200
assert 'Username or password is incorrect' in response.get_data(as_text=True) assert 'The username or password you entered is incorrect' in response.get_data(as_text=True)
def test_should_return_redirect_when_user_is_pending(app_, def test_should_return_redirect_when_user_is_pending(app_,