darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 17:38:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3775 from alphagov/set-sender-bug

Browse Source 
Fix bug with incorrect redirect to send_one_off
This commit is contained in:
David McDonald
2021-01-26 13:54:18 +00:00
committed by GitHub
parent 73afee8a12 9e477011d3
commit 8e3aeea9a0
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/templates.py
View File

@@ -65,7 +65,7 @@ def view_template(service_id, template_id):
if should_skip_template_page(template['template_type']):
return redirect(url_for(
'.send_one_off', service_id=service_id, template_id=template_id
'.set_sender', service_id=service_id, template_id=template_id
))
page_count = get_page_count_for_letter(template)

8
tests/app/main/views/test_templates.py
View File

@@ -531,7 +531,7 @@ def test_broadcast_template_doesnt_highlight_placeholders_but_does_count_charact
)
def test_caseworker_redirected_to_one_off(
def test_caseworker_redirected_to_set_sender_for_one_off(
client_request,
mock_get_service_templates,
mock_get_service_template,
@@ -548,7 +548,7 @@ def test_caseworker_redirected_to_one_off(
template_id=fake_uuid,
_expected_status=302,
_expected_redirect=url_for(
'main.send_one_off',
'main.set_sender',
service_id=SERVICE_ONE_ID,
template_id=fake_uuid,
_external=True,
@@ -556,7 +556,7 @@ def test_caseworker_redirected_to_one_off(
)
def test_user_with_only_send_and_view_redirected_to_one_off(
def test_user_with_only_send_and_view_redirected_to_set_sender_for_one_off(
client_request,
mock_get_service_templates,
mock_get_service_template,
@@ -575,7 +575,7 @@ def test_user_with_only_send_and_view_redirected_to_one_off(
template_id=fake_uuid,
_expected_status=302,
_expected_redirect=url_for(
'main.send_one_off',
'main.set_sender',
service_id=SERVICE_ONE_ID,
template_id=fake_uuid,
_external=True,