darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-03-12 14:22:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1433 from alphagov/imdad-fix-call-correct-endpoint-for-billing-usage

Browse Source 
Call the correct endpoint to retrieve yearly billing usage
This commit is contained in:
Imdad Ahad
2017-08-17 16:36:48 +01:00
committed by GitHub
parent fa99af6598 232912ab3b
commit 8c09d07f76
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notify_client/billing_api_client.py
View File

@@ -20,6 +20,6 @@ class BillingAPIClient(NotifyAdminAPIClient):
def get_service_usage(self, service_id, year=None):
return self.get(
'/service/{0}/billing/yearly-usage'.format(service_id),
'/service/{0}/billing/yearly-usage-summary'.format(service_id),
params=dict(year=year)
)

27
tests/app/notify_client/test_billing_client.py Normal file
View File

@@ -0,0 +1,27 @@
import uuid
from app.notify_client.billing_api_client import BillingAPIClient
def test_get_billing_units_calls_correct_endpoint(mocker, api_user_active):
service_id = uuid.uuid4()
expected_url = '/service/{}/billing/monthly-usage'.format(service_id)
client = BillingAPIClient()
mock_get = mocker.patch('app.notify_client.billing_api_client.BillingAPIClient.get')
client.get_billable_units(service_id, 2017)
mock_get.assert_called_once_with(expected_url, params={'year': 2017})
def test_get_get_service_usage_calls_correct_endpoint(mocker, api_user_active):
service_id = uuid.uuid4()
expected_url = '/service/{}/billing/yearly-usage-summary'.format(service_id)
client = BillingAPIClient()
mock_get = mocker.patch('app.notify_client.billing_api_client.BillingAPIClient.get')
client.get_service_usage(service_id, 2017)
mock_get.assert_called_once_with(expected_url, params={'year': 2017})