darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-19 04:36:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use file list pattern for list of files

Browse Source 
This means the page has the same appearance as other lists of stuff like
the notifications page.
This commit is contained in:
Chris Hill-Scott
2019-12-31 10:20:09 +00:00
parent fae18f3008
commit 8bcfb2fcde
2 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/templates/views/returned-letter-summary.html
View File

@@ -18,10 +18,13 @@
empty_message='If you have returned letter reports they will be listed here'
) %}
{% call field() %}
<a target="_blank" class="govuk_link"
href="{{url_for('.returned_letters_report', service_id=current_service.id, reported_at=item.reported_at)}}">Returned letters reported on {{ item.reported_at | format_date}} - {{ item.returned_letter_count}} {{ message_count_label(item.returned_letter_count, 'letter', suffix='')}}</a>
<a target="_blank" class="govuk_link file-list-filename"
href="{{url_for('.returned_letters_report', service_id=current_service.id, reported_at=item.reported_at)}}">{{ item.reported_at | format_date_normal }}</a>
<p class="file-list-hint">
{{ item.returned_letter_count}} {{ message_count_label(item.returned_letter_count, 'letter', suffix='')}}
</p>
{% endcall %}
{% endcall %}
</div>
{% endblock %}
{% endblock %}

16
tests/app/main/views/test_returned_letters.py
View File

@@ -15,9 +15,13 @@ def test_returned_letter_summary(
mock.assert_called_once_with(SERVICE_ONE_ID)
expected_text = "Returned letters reported on Tuesday 24 December 2019 - 30 letters"
assert page.h1.string.strip() == 'Returned letters'
assert normalize_spaces(page.select('.table-field-left-aligned')[0].text) == expected_text
assert normalize_spaces(
page.select_one('.table-field-left-aligned').text
) == (
'24 December 2019 '
'30 letters'
)
assert page.select_one('.table-field-left-aligned a')['href'] == url_for('.returned_letters_report',
service_id=SERVICE_ONE_ID,
reported_at='2019-12-24')
@@ -35,9 +39,13 @@ def test_returned_letter_summary_with_one_letter(
mock.assert_called_once_with(SERVICE_ONE_ID)
expected_text = "Returned letters reported on Tuesday 24 December 2019 - 1 letter"
assert page.h1.string.strip() == 'Returned letters'
assert normalize_spaces(page.select('.table-field-left-aligned')[0].text) == expected_text
assert normalize_spaces(
page.select_one('.table-field-left-aligned').text
) == (
'24 December 2019 '
'1 letter'
)
def test_returned_letters_reports(