darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-13 09:50:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

skip prometheus-client 0.10.0

Browse Source 
we saw exceptions on prod that I think might have caused a worker that
is being terminated to die ungracefully. While I'm not sure if this is
an actual problem that changed behaviour (app instances crashing and
restarting), at the very least it definitely polluted the logs and
obscured any actual issues we were having.

https://github.com/prometheus/client_python/releases/tag/v0.10.0

see the pending fix for this problem here:
https://github.com/prometheus/client_python/pull/644
This commit is contained in:
Leo Hemsted
2021-04-08 11:09:45 +01:00
parent 5d2b18e501
commit 8954dc2fae
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
requirements.in
View File

@@ -28,5 +28,6 @@ git+https://github.com/alphagov/notifications-utils.git@44.1.0#egg=notifications
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.8-alpha#egg=govuk-frontend-jinja==0.5.8-alpha
# gds-metrics requires prometheseus 0.2.0, override that requirement as later versions bring significant performance gains
prometheus-client==0.10.0
# version 0.10.0 introduced exceptions when workers crashed due to deprecating lower case `prometheus_multiproc_dir`.
prometheus-client>=0.9.0,!=0.10.0
gds-metrics==0.2.4

2
requirements.txt
View File

@@ -118,7 +118,7 @@ packaging==20.9
# via bleach
phonenumbers==8.12.20
# via notifications-utils
prometheus-client==0.10.0
prometheus-client==0.9.0
# via
# -r requirements.in
# gds-metrics