darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-04 17:42:05 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add missing test cases for precompiled validation messages

Browse Source
This commit is contained in:
Pea Tyczynska
2020-04-02 13:39:40 +01:00
parent 0a7fa1f799
commit 86ab0a6a0f
2 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/utils.py
View File

@@ -651,7 +651,7 @@ LETTER_VALIDATION_MESSAGES = {
),
},
'not-a-real-uk-postcode': {
'title': 'There’s a problem with the address on this letter',
'title': 'There’s a problem with the address for this letter',
'detail': (
'The last line of the address must be a real UK postcode.'
),

24
tests/app/test_utils.py
View File

@@ -483,6 +483,30 @@ def test_get_letter_validation_error_for_unknown_error():
'Save a new copy of your file and try again.'
),
),
(
'address-is-empty',
None,
'The address block is empty',
(
'You need to add a recipient address.'
'Files must meet our letter specification.'
),
(
'Validation failed because the address block is empty.'
'Files must meet our letter specification.'
),
),
(
'not-a-real-uk-postcode',
None,
'There’s a problem with the address for this letter',
(
'The last line of the address must be a real UK postcode.'
),
(
'Validation failed because the last line of the address is not a real UK postcode.'
),
),
])
def test_get_letter_validation_error_for_known_errors(
client_request,