darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 19:03:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix links which point at text message status anchor

Browse Source
This commit is contained in:
Chris Hill-Scott
2022-01-20 15:08:02 +00:00
parent 6414578c70
commit 862b95751b
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/formatters.py
View File

@@ -285,7 +285,7 @@ def format_notification_status_as_url(status, notification_type):
return {
'email': url(_anchor='email-statuses'),
'sms': url(_anchor='sms-statuses')
'sms': url(_anchor='text-message-statuses')
}.get(notification_type)

6
tests/app/main/test_formatters.py
View File

@@ -22,9 +22,9 @@ from app.formatters import (
('temporary-failure', 'email', partial(url_for, 'main.message_status', _anchor='email-statuses')),
('permanent-failure', 'email', partial(url_for, 'main.message_status', _anchor='email-statuses')),
('technical-failure', 'email', partial(url_for, 'main.message_status', _anchor='email-statuses')),
('temporary-failure', 'sms', partial(url_for, 'main.message_status', _anchor='sms-statuses')),
('permanent-failure', 'sms', partial(url_for, 'main.message_status', _anchor='sms-statuses')),
('technical-failure', 'sms', partial(url_for, 'main.message_status', _anchor='sms-statuses')),
('temporary-failure', 'sms', partial(url_for, 'main.message_status', _anchor='text-message-statuses')),
('permanent-failure', 'sms', partial(url_for, 'main.message_status', _anchor='text-message-statuses')),
('technical-failure', 'sms', partial(url_for, 'main.message_status', _anchor='text-message-statuses')),
# Letter statuses are never linked
('technical-failure', 'letter', lambda: None),
('cancelled', 'letter', lambda: None),

4
tests/app/main/views/test_index.py
View File

@@ -188,12 +188,12 @@ def test_message_status_page_contains_message_status_ids(client_request):
page = client_request.get('main.message_status')
assert page.find(id='email-statuses')
assert page.find(id='sms-statuses')
assert page.find(id='text-message-statuses')
def test_message_status_page_contains_link_to_support(client_request):
page = client_request.get('main.message_status')
sms_status_table = page.find(id='sms-statuses').findNext('tbody')
sms_status_table = page.find(id='text-message-statuses').findNext('tbody')
temp_fail_details_cell = sms_status_table.select_one('tr:nth-child(4) > td:nth-child(2)')
assert temp_fail_details_cell.find('a').attrs['href'] == url_for('main.support')