mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-09-10 18:22:37 -04:00
Update ServiceSmsSenderForm with new fields
Changes its StringField to GovukTextInputField. Includes changes to templates that use this form and associated tests.
This commit is contained in:
+1
-1
@@ -1563,7 +1563,7 @@ class ServiceReplyToEmailForm(StripWhitespaceForm):
|
||||
|
||||
|
||||
class ServiceSmsSenderForm(StripWhitespaceForm):
|
||||
sms_sender = StringField(
|
||||
sms_sender = GovukTextInputField(
|
||||
'Text message sender',
|
||||
validators=[
|
||||
DataRequired(message="Cannot be empty"),
|
||||
|
||||
@@ -16,11 +16,10 @@
|
||||
) }}
|
||||
|
||||
{% call form_wrapper() %}
|
||||
{{ textbox(
|
||||
form.sms_sender,
|
||||
width='1-4',
|
||||
hint='Up to 11 characters, letters, numbers and spaces only'
|
||||
) }}
|
||||
{{ form.sms_sender(param_extensions={
|
||||
"classes": "govuk-!-width-one-quarter",
|
||||
"hint": {"text": "Up to 11 characters, letters, numbers and spaces only"}
|
||||
}) }}
|
||||
{% if not first_sms_sender %}
|
||||
{{ form.is_default }}
|
||||
{% endif %}
|
||||
|
||||
@@ -22,11 +22,10 @@
|
||||
<span class="hint"> This phone number receives replies and cannot be changed </span>
|
||||
</p>
|
||||
{% else %}
|
||||
{{ textbox(
|
||||
form.sms_sender,
|
||||
width='1-4',
|
||||
hint='Up to 11 characters, letters, numbers and spaces only'
|
||||
) }}
|
||||
{{ form.sms_sender(param_extensions={
|
||||
"classes": "govuk-!-width-one-quarter",
|
||||
"hint": {"text": "Up to 11 characters, letters, numbers and spaces only"}
|
||||
}) }}
|
||||
{% endif %}
|
||||
{% if form.is_default.data %}
|
||||
<p class="form-group">
|
||||
|
||||
@@ -2285,14 +2285,14 @@ def test_incorrect_sms_sender_input(
|
||||
_expected_status=(200 if expected_error else 302)
|
||||
)
|
||||
|
||||
error_message = page.select_one('.error-message')
|
||||
error_message = page.select_one('.govuk-error-message')
|
||||
count_of_api_calls = len(mock_add_sms_sender.call_args_list)
|
||||
|
||||
if not expected_error:
|
||||
assert not error_message
|
||||
assert count_of_api_calls == 1
|
||||
else:
|
||||
assert normalize_spaces(error_message.text) == expected_error
|
||||
assert expected_error in error_message.text
|
||||
assert count_of_api_calls == 0
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user