darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Split into two pages

Browse Source 
A lot of users aren’t reading or paying attention to the checklist on
the request to go live page. We think that we can get more people to
read it by putting it on its own page, where users won’t jump straight
to filling in the form.

This will, later on, let us make this page smarter by automatically
detecting if they’ve done the necessary things.
This commit is contained in:
Chris Hill-Scott
2018-02-20 12:15:35 +00:00
parent 4e2b4b5ac7
commit 7dc278c959
4 changed files with 100 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/app/main/views/test_service_settings.py
View File

@@ -425,13 +425,26 @@ def test_should_raise_duplicate_name_handled(
assert mock_verify_password.called
def test_should_show_request_to_go_live(
def test_should_show_request_to_go_live_checklist(
client_request,
):
page = client_request.get(
'main.request_to_go_live', service_id=SERVICE_ONE_ID
)
assert page.h1.text == 'Request to go live'
assert page.select_one('main .button')['href'] == url_for(
'main.submit_request_to_go_live',
service_id=SERVICE_ONE_ID,
)
def test_should_show_request_to_go_live(
client_request,
):
page = client_request.get(
'main.submit_request_to_go_live', service_id=SERVICE_ONE_ID
)
assert page.h1.text == 'Request to go live'
for channel, label in (
('email', 'Emails'),
('sms', 'Text messages'),
@@ -462,7 +475,7 @@ def test_should_redirect_after_request_to_go_live(
):
mock_post = mocker.patch('app.main.views.service_settings.deskpro_client.create_ticket')
page = client_request.post(
'main.request_to_go_live',
'main.submit_request_to_go_live',
service_id=SERVICE_ONE_ID,
_data={
'mou': 'yes',
@@ -506,6 +519,7 @@ def test_should_redirect_after_request_to_go_live(
'main.service_name_change',
'main.service_name_change_confirm',
'main.request_to_go_live',
'main.submit_request_to_go_live',
'main.archive_service'
])
def test_route_permissions(
@@ -537,6 +551,7 @@ def test_route_permissions(
'main.service_name_change',
'main.service_name_change_confirm',
'main.request_to_go_live',
'main.submit_request_to_go_live',
'main.service_switch_live',
'main.service_switch_research_mode',
'main.archive_service',
@@ -565,6 +580,7 @@ def test_route_invalid_permissions(
'main.service_name_change',
'main.service_name_change_confirm',
'main.request_to_go_live',
'main.submit_request_to_go_live',
])
def test_route_for_platform_admin(
mocker,