Rename endpoint

Every endpoint in this file is to do with a service. Putting service in
the name is redundant.

app/main/views/service_settings.py

@@ -161,7 +161,7 @@ def service_name_change_confirm(service_id):
 @main.route("/services/<service_id>/service-settings/request-to-go-live", methods=['GET', 'POST'])
 @login_required
 @user_has_permissions('manage_settings', admin_override=True)
-def service_request_to_go_live(service_id):
+def request_to_go_live(service_id):
     form = RequestToGoLiveForm()
 
     if form.validate_on_submit():

app/templates/views/service-settings.html

@@ -228,7 +228,7 @@
 
       <p>
         To remove these restrictions
-        <a href="{{ url_for('.service_request_to_go_live', service_id=current_service.id) }}">request to go live</a>.
+        <a href="{{ url_for('.request_to_go_live', service_id=current_service.id) }}">request to go live</a>.
       </p>
     {% else %}
       <h2 class="heading-medium">Your service is live</h2>

tests/app/main/views/test_service_settings.py

@@ -429,7 +429,7 @@ def test_should_show_request_to_go_live(
     client_request,
 ):
     page = client_request.get(
-        'main.service_request_to_go_live', service_id=SERVICE_ONE_ID
+        'main.request_to_go_live', service_id=SERVICE_ONE_ID
     )
     assert page.h1.text == 'Request to go live'
     for channel, label in (
@@ -462,7 +462,7 @@ def test_should_redirect_after_request_to_go_live(
 ):
     mock_post = mocker.patch('app.main.views.service_settings.deskpro_client.create_ticket')
     page = client_request.post(
-        'main.service_request_to_go_live',
+        'main.request_to_go_live',
         service_id=SERVICE_ONE_ID,
         _data={
             'mou': 'yes',
@@ -505,7 +505,7 @@ def test_should_redirect_after_request_to_go_live(
     'main.service_settings',
     'main.service_name_change',
     'main.service_name_change_confirm',
-    'main.service_request_to_go_live',
+    'main.request_to_go_live',
     'main.archive_service'
 ])
 def test_route_permissions(
@@ -536,7 +536,7 @@ def test_route_permissions(
     'main.service_settings',
     'main.service_name_change',
     'main.service_name_change_confirm',
-    'main.service_request_to_go_live',
+    'main.request_to_go_live',
     'main.service_switch_live',
     'main.service_switch_research_mode',
     'main.archive_service',
@@ -564,7 +564,7 @@ def test_route_invalid_permissions(
     'main.service_settings',
     'main.service_name_change',
     'main.service_name_change_confirm',
-    'main.service_request_to_go_live',
+    'main.request_to_go_live',
 ])
 def test_route_for_platform_admin(
         mocker,