Merge pull request #2415 from alphagov/add-edit-folders-permission-button

Add platform admin button for edit_folders permission

app/main/views/service_settings.py

@@ -363,6 +363,14 @@ def service_switch_can_upload_document(service_id):
     return render_template('views/service-settings/contact_link.html', form=form)
 
 
+@main.route("/services/<service_id>/service-settings/can-edit-folders")
+@login_required
+@user_is_platform_admin
+def service_switch_can_edit_folders(service_id):
+    switch_service_permissions(service_id, 'edit_folders')
+    return redirect(url_for('.service_settings', service_id=service_id))
+
+
 @main.route("/services/<service_id>/service-settings/archive", methods=['GET', 'POST'])
 @login_required
 @user_has_permissions('manage_service')

app/navigation.py

@@ -237,6 +237,7 @@ class HeaderNavigation(Navigation):
         'service_set_sms_prefix',
         'service_settings',
         'service_sms_senders',
+        'service_switch_can_edit_folders',
         'service_switch_can_send_email',
         'service_switch_can_send_precompiled_letter',
         'service_switch_can_upload_document',
@@ -466,6 +467,7 @@ class MainNavigation(Navigation):
         'service_dashboard_updates',
         'service_delete_email_reply_to',
         'service_delete_sms_sender',
+        'service_switch_can_edit_folders',
         'service_switch_can_send_email',
         'service_switch_can_send_precompiled_letter',
         'service_switch_can_upload_document',
@@ -688,6 +690,7 @@ class CaseworkNavigation(Navigation):
         'service_set_sms_prefix',
         'service_settings',
         'service_sms_senders',
+        'service_switch_can_edit_folders',
         'service_switch_can_send_email',
         'service_switch_can_send_precompiled_letter',
         'service_switch_can_send_sms',
@@ -918,6 +921,7 @@ class OrgNavigation(Navigation):
         'service_set_sms_prefix',
         'service_settings',
         'service_sms_senders',
+        'service_switch_can_edit_folders',
         'service_switch_can_send_email',
         'service_switch_can_send_precompiled_letter',
         'service_switch_can_upload_document',

app/templates/views/service-settings.html

@@ -378,6 +378,11 @@
              {{ 'Stop uploading documents' if 'upload_document' in current_service.permissions else 'Allow to upload documents' }}
            </a>
         </li>
+        <li class="bottom-gutter">
+           <a href="{{ url_for('.service_switch_can_edit_folders', service_id=current_service.id) }}" class="button">
+             {{ 'Stop editing folders' if 'edit_folders' in current_service.permissions else 'Allow to edit folders' }}
+           </a>
+        </li>
         {% if current_service.active %}
           <li class="bottom-gutter">
             <a href="{{ url_for('.archive_service', service_id=current_service.id) }}" class="button">

tests/app/main/views/service_settings/test_service_setting_permissions.py

@@ -45,6 +45,9 @@ def get_service_settings_page(
     ({'permissions': []},
         '.service_switch_can_upload_document', {}, 'Allow to upload documents'),
 
+    ({'permissions': ['edit_folders']}, '.service_switch_can_edit_folders', {}, 'Stop editing folders'),
+    ({'permissions': []}, '.service_switch_can_edit_folders', {}, 'Allow to edit folders'),
+
     ({'permissions': ['sms']}, '.service_set_inbound_number', {'set_inbound_sms': True}, 'Allow inbound sms'),
 
     ({'active': True}, '.archive_service', {}, 'Archive service'),