darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1334 from alphagov/fix-missing-recipient-on-notification-page

Browse Source 
Fix missing recipients on notification page
This commit is contained in:
Chris Hill-Scott
2017-06-23 15:03:10 +01:00
committed by GitHub
parent f8a3132d8b 4b02612d93
commit 6f3bcff32f
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
app/main/views/notifications.py
View File

@@ -57,7 +57,7 @@ def view_notification(service_id, notification_id):
),
show_recipient=True,
)
template.values = notification['personalisation']
template.values = get_all_personalisation_from_notification(notification)
if notification['job']:
job = job_api_client.get_job(service_id, notification['job']['id'])['data']
else:
@@ -106,3 +106,18 @@ def get_single_notification_partials(notification):
notification=notification
),
}
def get_all_personalisation_from_notification(notification):
if notification['template']['template_type'] == 'email':
return dict(
email_address=notification['to'],
**notification['personalisation']
)
if notification['template']['template_type'] == 'sms':
return dict(
phone_number=notification['to'],
**notification['personalisation']
)
if notification['template']['template_type'] == 'letter':
return notification['personalisation']

3
tests/app/main/views/test_notifications.py
View File

@@ -43,6 +43,9 @@ def test_notification_status_page_shows_details(
notification_id=fake_uuid
)
assert normalize_spaces(page.select('.sms-message-recipient')[0].text) == (
'To: 07123456789'
)
assert normalize_spaces(page.select('.sms-message-wrapper')[0].text) == (
'service one: hello Jo'
)