darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-27 04:31:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove functions and comments redundant after monthly_billing removal

Browse Source
This commit is contained in:
Pea Tyczynska
2018-07-25 11:32:28 +01:00
parent 72e8303987
commit 6d2aad5561
2 changed files with 0 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/notify_client/billing_api_client.py
View File

@@ -7,26 +7,12 @@ class BillingAPIClient(NotifyAdminAPIClient):
def __init__(self):
super().__init__("a" * 73, "b")
def get_billable_units(self, service_id, year):
return self.get(
'/service/{0}/billing/monthly-usage'.format(service_id),
params=dict(year=year)
)
def get_service_usage(self, service_id, year=None):
return self.get(
'/service/{0}/billing/yearly-usage-summary'.format(service_id),
params=dict(year=year)
)
# Temporary methods to compare the usage before and after using ft_billing
def get_billable_units_ft(self, service_id, year):
return self.get(
'/service/{0}/billing/ft-monthly-usage'.format(service_id),
params=dict(year=year)
)
# Temporary methods to compare the usage before and after using ft_billing
def get_service_usage_ft(self, service_id, year=None):
return self.get(
'/service/{0}/billing/ft-yearly-usage-summary'.format(service_id),

24
tests/app/notify_client/test_billing_client.py
View File

@@ -3,30 +3,6 @@ import uuid
from app.notify_client.billing_api_client import BillingAPIClient
def test_get_billing_units_calls_correct_endpoint(mocker, api_user_active):
service_id = uuid.uuid4()
expected_url = '/service/{}/billing/monthly-usage'.format(service_id)
client = BillingAPIClient()
mock_get = mocker.patch('app.notify_client.billing_api_client.BillingAPIClient.get')
client.get_billable_units(service_id, 2017)
mock_get.assert_called_once_with(expected_url, params={'year': 2017})
def test_get_get_service_usage_calls_correct_endpoint(mocker, api_user_active):
service_id = uuid.uuid4()
expected_url = '/service/{}/billing/yearly-usage-summary'.format(service_id)
client = BillingAPIClient()
mock_get = mocker.patch('app.notify_client.billing_api_client.BillingAPIClient.get')
client.get_service_usage(service_id, 2017)
mock_get.assert_called_once_with(expected_url, params={'year': 2017})
def test_get_free_sms_fragment_limit_for_year_correct_endpoint(mocker, api_user_active):
service_id = uuid.uuid4()
expected_url = '/service/{}/billing/free-sms-fragment-limit'.format(service_id)