Redirect from confirmation page if session empty

This commit is contained in:
Pea Tyczynska
2019-02-22 16:13:46 +00:00
parent 4faf44b5c5
commit 6c406ae5cd
2 changed files with 24 additions and 1 deletions

View File

@@ -164,7 +164,14 @@ def edit_user_email(service_id, user_id):
@user_has_permissions('manage_service')
def confirm_edit_user_email(service_id, user_id):
user = user_api_client.get_user(user_id)
new_email = session['team_member_email_change']
if 'team_member_email_change' in session:
new_email = session['team_member_email_change']
else:
return redirect(url_for(
'.edit_user_email',
service_id=service_id,
user_id=user_id
))
if request.method == 'POST':
try:
user_api_client.update_user_attribute(user_id, email_address=new_email)

View File

@@ -840,6 +840,22 @@ def test_confirm_edit_user_email_page(
assert response.status_code == 200
def test_confirm_edit_user_email_page_redirects_if_session_empty(
logged_in_client,
active_user_with_permissions,
service_one,
mocker,
mock_get_user,
):
response = logged_in_client.get(url_for(
'main.confirm_edit_user_email',
service_id=service_one['id'],
user_id=active_user_with_permissions.id
))
assert response.status_code == 302
assert 'Confirm change of email address' not in response.get_data(as_text=True)
def test_confirm_edit_user_email_changes_user_email(
logged_in_client,
active_user_with_permissions,