fixed end2end

app/main/views/index.py

@@ -11,8 +11,6 @@ from app.main.views.sub_navigation_dictionaries import features_nav, using_notif
 from app.utils.user import user_is_logged_in
 from notifications_utils.url_safe_token import generate_token
 
-login_dot_gov_url = os.getenv("LOGIN_DOT_GOV_INITIAL_SIGNIN_URL")
-
 
 @main.route("/")
 def index():
@@ -32,7 +30,6 @@ def index():
         "views/signedout.html",
         sms_rate=CURRENT_SMS_RATE,
         counts=status_api_client.get_count_of_live_services_and_organizations(),
-        login_dot_gov_url=login_dot_gov_url,
         initial_signin_url=url,
     )
 

tests/app/main/views/test_index.py

@@ -21,8 +21,7 @@ def test_non_logged_in_user_can_see_homepage(
 
     assert page.select_one(
         "a.usa-button.login-button.login-button--primary.margin-right-2"
-    )["href"]
-
+    ).text == "Sign in with \n"
     assert page.select_one("meta[name=description]") is not None
     # This area is hidden for the pilot
     # assert normalize_spaces(page.select_one('#whos-using-notify').text) == (

tests/end_to_end/test_landing_and_sign_in_pages.py

@@ -31,7 +31,9 @@ def test_landing_page(end_to_end_context):
     expect(benefits_studio_email).to_be_visible()
 
     # Check to make sure the sign-in button and email links are correct.
-    expect(sign_in_button).to_have_attribute("href")
+    href_value = sign_in_button.get_attribute('href')
+    assert href_value is not None, "The sign-in button does not have an href attribute"
+    # expect(sign_in_button).to_have_attribute("href")
     expect(benefits_studio_email).to_have_attribute(
         "href", "mailto:tts-benefits-studio@gsa.gov"
     )