Store original filename as S3 metadata

By doing this we no longer have to store it in the session. This is the
last thing that’s currently in the session, so removing it means we can
drop session storage for file uploads entirely.
This commit is contained in:
Chris Hill-Scott
2018-04-30 10:06:33 +01:00
parent 2774cf45f2
commit 66e6538d95
2 changed files with 4 additions and 0 deletions

View File

@@ -555,6 +555,7 @@ def _check_messages(service_id, template_id, upload_id, preview_row, letters_as_
notification_count=len(recipients),
template_id=str(template_id),
valid=True,
original_file_name=request.args.get('original_file_name'),
)
else:
session['file_uploads'].pop(upload_id)

View File

@@ -590,6 +590,7 @@ def test_upload_valid_csv_shows_preview_and_table(
service_id=SERVICE_ONE_ID,
template_id=fake_uuid,
upload_id=fake_uuid,
original_file_name='example.csv',
**extra_args
)
@@ -599,6 +600,7 @@ def test_upload_valid_csv_shows_preview_and_table(
notification_count=3,
template_id=fake_uuid,
valid=True,
original_file_name='example.csv',
)
assert page.h1.text.strip() == 'Preview of Two week reminder'
@@ -1506,6 +1508,7 @@ def test_upload_csvfile_with_valid_phone_shows_all_numbers(
notification_count=53,
template_id=fake_uuid,
valid=True,
original_file_name='valid.csv',
)
content = response.get_data(as_text=True)