darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-28 11:49:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename method

Browse Source 
Starting with `is` helps indicate that it’s going to return a boolean,
not perform an action (which is what a verb like `show` implies).
This commit is contained in:
Chris Hill-Scott
2018-11-13 12:31:31 +00:00
parent 045a4bb7f1
commit 63060d926f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/service.py
View File

@@ -303,11 +303,11 @@ class Service():
folder for folder in self.all_template_folders
if (
folder['parent_id'] == parent_folder_id and
self.show_folder(folder['id'], template_type)
self.is_folder_visible(folder['id'], template_type)
)
]
def show_folder(self, template_folder_id, template_type='all'):
def is_folder_visible(self, template_folder_id, template_type='all'):
if template_type == 'all':
return True
@@ -316,7 +316,7 @@ class Service():
return True
if any(
self.show_folder(child_folder['id'], template_type)
self.is_folder_visible(child_folder['id'], template_type)
for child_folder in self.get_template_folders(template_type, template_folder_id)
):
return True