darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Used url_for and redirect

Browse Source 
- url_for instead of constructing the url manually
- Used redirect instead of RequestRedirect to be more consistent with
other code
This commit is contained in:
Richard Chapman
2017-11-24 16:34:45 +00:00
parent 155e432aa6
commit 629593291c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/views/dashboard.py
View File

@@ -12,7 +12,7 @@ from flask import (
) )
from flask_login import login_required from flask_login import login_required
from notifications_utils.recipients import format_phone_number_human_readable from notifications_utils.recipients import format_phone_number_human_readable
from werkzeug.routing import RequestRedirect from werkzeug.utils import redirect
from app.main import main from app.main import main
from app import ( from app import (
@@ -76,7 +76,7 @@ def service_dashboard_updates(service_id):
@user_has_permissions('view_activity', admin_override=True) @user_has_permissions('view_activity', admin_override=True)
def template_history(service_id): def template_history(service_id):
raise RequestRedirect("/services/{}/template-usage".format(service_id)) return redirect(url_for('main.template_usage', service_id=service_id), code=301)
@main.route("/services/<service_id>/template-usage") @main.route("/services/<service_id>/template-usage")