From 629593291c74ee2c69aaf55f7273a23da61eff01 Mon Sep 17 00:00:00 2001 From: Richard Chapman Date: Fri, 24 Nov 2017 16:34:45 +0000 Subject: [PATCH] Used url_for and redirect - url_for instead of constructing the url manually - Used redirect instead of RequestRedirect to be more consistent with other code --- app/main/views/dashboard.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/main/views/dashboard.py b/app/main/views/dashboard.py index 42ed6947d..4c2b05b91 100644 --- a/app/main/views/dashboard.py +++ b/app/main/views/dashboard.py @@ -12,7 +12,7 @@ from flask import ( ) from flask_login import login_required from notifications_utils.recipients import format_phone_number_human_readable -from werkzeug.routing import RequestRedirect +from werkzeug.utils import redirect from app.main import main from app import ( @@ -76,7 +76,7 @@ def service_dashboard_updates(service_id): @user_has_permissions('view_activity', admin_override=True) def template_history(service_id): - raise RequestRedirect("/services/{}/template-usage".format(service_id)) + return redirect(url_for('main.template_usage', service_id=service_id), code=301) @main.route("/services//template-usage")