allow non-gov reply to email addresses

we reckon users will like to see gov reply-to email addresses because
it will improve their confidence in the email.

however, some services, for a few complex reasons, don't want a gov
reply to address. rather than add their specific domains to the
whitelist for signups etc, just make reply tos allowed from any domain.

We vet reply-tos before services go live anyway.
This commit is contained in:
Leo Hemsted
2018-04-30 14:00:05 +01:00
parent 6e522cb87f
commit 60202cf5af
2 changed files with 3 additions and 4 deletions

View File

@@ -579,7 +579,7 @@ class ProviderForm(StripWhitespaceForm):
class ServiceReplyToEmailForm(StripWhitespaceForm):
email_address = email_address(label='Email reply to address')
email_address = email_address(label='Email reply to address', gov_user=False)
is_default = BooleanField("Make this email address the default")

View File

@@ -891,7 +891,6 @@ def test_no_senders_message_shows(
@pytest.mark.parametrize('reply_to_input, expected_error', [
('', 'Cant be empty'),
('testtest', 'Enter a valid email address'),
('test@hello.com', 'Enter a government email address. If you think you should have access contact us')
])
def test_incorrect_reply_to_email_address_input(
reply_to_input,
@@ -977,7 +976,7 @@ def test_add_reply_to_email_address(
mock_add_reply_to_email_address
):
fixture(mocker)
data['email_address'] = "test@example.gov.uk"
data['email_address'] = "test@example.com"
client_request.post(
'main.service_add_email_reply_to',
service_id=SERVICE_ONE_ID,
@@ -986,7 +985,7 @@ def test_add_reply_to_email_address(
mock_add_reply_to_email_address.assert_called_once_with(
SERVICE_ONE_ID,
email_address="test@example.gov.uk",
email_address="test@example.com",
is_default=api_default_args
)