darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-28 18:10:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Sort services alphabetically when copying template

Browse Source 
If you have a lot of services it’s hard to find the one you’re looking
for if the sort order is a mixture of `created_by` and which ones belong
to an organisation.

Since the templates within the services are sorted alphabetically it
makes sense to also sort the services alphabetically.
This commit is contained in:
Chris Hill-Scott
2018-08-09 13:33:08 +01:00
parent 2dde1ad36f
commit 55d051d95a
2 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/notify_client/user_api_client.py
View File

@@ -214,9 +214,10 @@ class UserApiClient(NotifyAdminAPIClient):
def get_services_for_user(self, user):
orgs_and_services_for_user = self.get_organisations_and_services_for_user(user)
return orgs_and_services_for_user['services_without_organisations'] + next(chain(
all_services = orgs_and_services_for_user['services_without_organisations'] + next(chain(
org['services'] for org in orgs_and_services_for_user['organisations']
), [])
return sorted(all_services, key=lambda service: service['name'])
def get_service_ids_for_user(self, user):
return {

30
tests/app/main/views/test_templates.py
View File

@@ -422,21 +422,6 @@ def test_choose_a_template_to_copy(
assert normalize_spaces(
page.select_one('main nav').text
) == normalize_spaces(
'Service 1 '
' sms_template_one '
' Text message template'
' sms_template_two Text message template'
' email_template_one Email template'
' email_template_two Email template '
'Service 2 '
' sms_template_one'
' Text message template'
' sms_template_two'
' Text message template'
' email_template_one'
' Email template'
' email_template_two'
' Email template '
'Org 1 service 1 '
' sms_template_one'
' Text message template'
@@ -454,6 +439,21 @@ def test_choose_a_template_to_copy(
' email_template_one'
' Email template'
' email_template_two'
' Email template '
'Service 1 '
' sms_template_one '
' Text message template'
' sms_template_two Text message template'
' email_template_one Email template'
' email_template_two Email template '
'Service 2 '
' sms_template_one'
' Text message template'
' sms_template_two'
' Text message template'
' email_template_one'
' Email template'
' email_template_two'
' Email template'
)