801 - Moving Send message link from inside the side nav to a button

app/templates/main_nav.html

@@ -1,13 +1,15 @@
 {% if help %}
   {% include 'partials/tour.html' %}
 {% else %}
-<nav class="nav margin-bottom-5">
+<nav class="nav">
+  <a class="usa-button margin-top-1 margin-bottom-5 width-full"
+    href="{{ url_for('.choose_template', service_id=current_service.id) }}">Send messages</a>
   <ul class="usa-sidenav">
   {% if current_user.has_permissions() %}
     {% if current_user.has_permissions('view_activity') %}
       <li class="usa-sidenav__item"><a class="{{ main_navigation.is_selected('dashboard') }}" href="{{ url_for('.service_dashboard', service_id=current_service.id) }}">Dashboard</a></li>
     {% endif %}
-      <li class="usa-sidenav__item"><a class="{{ main_navigation.is_selected('templates') }}" href="{{ url_for('.choose_template', service_id=current_service.id) }}">Send messages</a></li>
+      {# <li class="usa-sidenav__item"><a class="{{ main_navigation.is_selected('templates') }}" href="{{ url_for('.choose_template', service_id=current_service.id) }}">Send messages</a></li> #}
     {% if not current_user.has_permissions('view_activity') %}
       <li class="usa-sidenav__item"><a class="{{ casework_navigation.is_selected('sent-messages') }}" href="{{ url_for('.view_notifications', service_id=current_service.id, status='sending,delivered,failed') }}">Sent messages</a></li>
     {% endif %}
@@ -27,8 +29,8 @@
   {% endif %}
   </ul>
 </nav>
-    <div>
-        <p class="usa--body bold margin-bottom-1">Messages Left Across Services</p>
-        <p>{{ daily_global_messages_remaining }}</p>
-    </div>
+<div>
+    <p class="usa--body bold ">Messages Left Across Services</p>
+    <p>{{ daily_global_messages_remaining }}</p>
+</div>
 {% endif %}

tests/app/main/test_permissions.py

@@ -122,7 +122,6 @@ def test_service_navigation_for_org_user(
         (
             [],
             (
-                "Send messages",
                 "Sent messages",
                 "Team members",
             ),
@@ -131,7 +130,6 @@ def test_service_navigation_for_org_user(
         (
             [ORGANISATION_ID],
             (
-                "Send messages",
                 "Sent messages",
                 "Team members",
                 "Usage",

tests/app/main/views/accounts/test_choose_accounts.py

@@ -361,7 +361,7 @@ def test_should_show_back_to_service_if_user_belongs_to_service(
 ):
     mock_get_service.return_value = service_one
     expected_page_text = (
-        "Test Service Switch service " "" "Dashboard " "Send messages " "Team members"
+        "Test Service Switch service " "Dashboard" "Team members"
     )  # TODO: set sidebar variables in common test module
 
     page = client_request.get(

tests/app/test_navigation.py

@@ -354,7 +354,6 @@ def test_raises_on_invalid_navigation_item(client_request, navigation_instance):
 @pytest.mark.parametrize(
     ("endpoint", "selected_nav_item"),
     [
-        ("main.choose_template", "Send messages"),
         ("main.manage_users", "Team members"),
     ],
 )
@@ -444,7 +443,7 @@ def test_caseworkers_get_caseworking_navigation(
     client_request.login(active_caseworking_user)
     page = client_request.get("main.choose_template", service_id=SERVICE_ONE_ID)
     assert normalize_spaces(page.select_one("header + .grid-container nav").text) == (
-        "Send messages Sent messages Team members"
+        "Sent messages Team members"
     )
 
 
@@ -459,5 +458,5 @@ def test_caseworkers_see_jobs_nav_if_jobs_exist(
     client_request.login(active_caseworking_user)
     page = client_request.get("main.choose_template", service_id=SERVICE_ONE_ID)
     assert normalize_spaces(page.select_one("header + .grid-container nav").text) == (
-        "Send messages Sent messages Team members"
+        "Sent messages Team members"
     )