darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-18 05:30:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Show letters in basic view

Browse Source 
We were taking letters away from basic view because there’s no one-off
sending of letters.

But now that basic view isn’t an opt-in thing but something we’re
rolling out to all users who only have the ‘send’ permission it feels
like too drastic a change to remove letters.
This commit is contained in:
Chris Hill-Scott
2018-08-07 11:45:19 +01:00
parent 3e14e5e52b
commit 5108187cab
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/main/views/templates.py
View File

@@ -111,10 +111,7 @@ def start_tour(service_id, template_id):
def choose_template(service_id, template_type='all'):
templates = service_api_client.get_service_templates(service_id)['data']
letters_available = (
current_service.has_permission('letter') and
current_user.has_permissions('view_activity')
)
letters_available = current_service.has_permission('letter')
available_template_types = list(filter(None, (
'email',

6
tests/app/main/views/test_templates.py
View File

@@ -74,19 +74,21 @@ from tests.conftest import single_letter_contact_block
active_caseworking_user,
'Templates',
{},
['Text message', 'Email'],
['Text message', 'Email', 'Letter'],
[
'sms_template_one',
'sms_template_two',
'email_template_one',
'email_template_two',
'letter_template_one',
'letter_template_two',
],
),
(
active_caseworking_user,
'Templates',
{'template_type': 'email'},
['All', 'Text message'],
['All', 'Text message', 'Letter'],
['email_template_one', 'email_template_two'],
),
]