darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-04 23:18:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename endpoint

Browse Source 
Every endpoint in this file is to do with a service. Putting service in
the name is redundant.
This commit is contained in:
Chris Hill-Scott
2018-02-20 11:06:08 +00:00
parent ce4ffcde3c
commit 4e2b4b5ac7
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/service_settings.py
View File

@@ -161,7 +161,7 @@ def service_name_change_confirm(service_id):
@main.route("/services/<service_id>/service-settings/request-to-go-live", methods=['GET', 'POST']) @main.route("/services/<service_id>/service-settings/request-to-go-live", methods=['GET', 'POST'])
@login_required @login_required
@user_has_permissions('manage_settings', admin_override=True) @user_has_permissions('manage_settings', admin_override=True)
def service_request_to_go_live(service_id): def request_to_go_live(service_id):
form = RequestToGoLiveForm() form = RequestToGoLiveForm()
if form.validate_on_submit(): if form.validate_on_submit():

2
app/templates/views/service-settings.html
View File

@@ -228,7 +228,7 @@
<p> <p>
To remove these restrictions To remove these restrictions
<a href="{{ url_for('.service_request_to_go_live', service_id=current_service.id) }}">request to go live</a>. <a href="{{ url_for('.request_to_go_live', service_id=current_service.id) }}">request to go live</a>.
</p> </p>
{% else %} {% else %}
<h2 class="heading-medium">Your service is live</h2> <h2 class="heading-medium">Your service is live</h2>

10
tests/app/main/views/test_service_settings.py
View File

@@ -429,7 +429,7 @@ def test_should_show_request_to_go_live(
client_request, client_request,
): ):
page = client_request.get( page = client_request.get(
'main.service_request_to_go_live', service_id=SERVICE_ONE_ID 'main.request_to_go_live', service_id=SERVICE_ONE_ID
) )
assert page.h1.text == 'Request to go live' assert page.h1.text == 'Request to go live'
for channel, label in ( for channel, label in (
@@ -462,7 +462,7 @@ def test_should_redirect_after_request_to_go_live(
): ):
mock_post = mocker.patch('app.main.views.service_settings.deskpro_client.create_ticket') mock_post = mocker.patch('app.main.views.service_settings.deskpro_client.create_ticket')
page = client_request.post( page = client_request.post(
'main.service_request_to_go_live', 'main.request_to_go_live',
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,
_data={ _data={
'mou': 'yes', 'mou': 'yes',
@@ -505,7 +505,7 @@ def test_should_redirect_after_request_to_go_live(
'main.service_settings', 'main.service_settings',
'main.service_name_change', 'main.service_name_change',
'main.service_name_change_confirm', 'main.service_name_change_confirm',
'main.service_request_to_go_live', 'main.request_to_go_live',
'main.archive_service' 'main.archive_service'
]) ])
def test_route_permissions( def test_route_permissions(
@@ -536,7 +536,7 @@ def test_route_permissions(
'main.service_settings', 'main.service_settings',
'main.service_name_change', 'main.service_name_change',
'main.service_name_change_confirm', 'main.service_name_change_confirm',
'main.service_request_to_go_live', 'main.request_to_go_live',
'main.service_switch_live', 'main.service_switch_live',
'main.service_switch_research_mode', 'main.service_switch_research_mode',
'main.archive_service', 'main.archive_service',
@@ -564,7 +564,7 @@ def test_route_invalid_permissions(
'main.service_settings', 'main.service_settings',
'main.service_name_change', 'main.service_name_change',
'main.service_name_change_confirm', 'main.service_name_change_confirm',
'main.service_request_to_go_live', 'main.request_to_go_live',
]) ])
def test_route_for_platform_admin( def test_route_for_platform_admin(
mocker, mocker,