darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-08 10:28:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant conditional for CF Redis

Browse Source 
This is now used in all environments and we've removed support for
non-CF Redis [1].

[1]: https://github.com/alphagov/notifications-admin/pull/4213
This commit is contained in:
Ben Thorner
2022-04-20 11:10:12 +01:00
committed by Leo Hemsted
parent d4a58c706b
commit 4a3ba97115
2 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/cloudfoundry_config.py
View File

@@ -4,7 +4,4 @@ import os
def extract_cloudfoundry_config():
vcap_services = json.loads(os.environ['VCAP_SERVICES'])
# Redis config
if 'redis' in vcap_services:
os.environ['REDIS_URL'] = vcap_services['redis'][0]['credentials']['uri']
os.environ['REDIS_URL'] = vcap_services['redis'][0]['credentials']['uri']

8
tests/app/test_cloudfoundry_config.py
View File

@@ -22,11 +22,3 @@ def test_extract_cloudfoundry_config_populates_other_vars(os_environ, vcap_servi
extract_cloudfoundry_config()
assert os.environ['REDIS_URL'] == 'redis uri'
def test_extract_cloudfoundry_config_copes_if_redis_not_set(os_environ, vcap_services):
del vcap_services['redis']
os.environ['VCAP_SERVICES'] = json.dumps(vcap_services)
extract_cloudfoundry_config()
assert 'REDIS_URL' not in os.environ