darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 02:42:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove the verbs from the navigation

Browse Source 
Because ‘Send text messages’ isn’t very helpful if you’re looking to
edit a template.

It also helps front-load the navigation, ie ‘Team’ is the first word,
rather than the more generic ‘Manage’.
This commit is contained in:
Chris Hill-Scott
2016-04-01 10:42:23 +01:00
parent 5f9605d605
commit 42cb4b0d99
5 changed files with 17 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
app/main/views/send.py
View File

@@ -29,18 +29,6 @@ from app import (job_api_client, service_api_client)
from app.utils import user_has_permissions, get_errors_for_csv
send_messages_page_headings = {
'email': 'Send emails',
'sms': 'Send text messages'
}
manage_templates_page_headings = {
'email': 'Email templates',
'sms': 'Text message templates'
}
def get_send_button_text(template_type, number_of_messages):
if 1 == number_of_messages:
return {
@@ -55,11 +43,10 @@ def get_send_button_text(template_type, number_of_messages):
def get_page_headings(template_type):
# User has manage_service role
if current_user.has_permissions(['send_texts', 'send_emails', 'send_letters']):
return send_messages_page_headings[template_type]
else:
return manage_templates_page_headings[template_type]
return {
'email': 'Email templates',
'sms': 'Text message templates'
}[template_type]
@main.route("/services/<service_id>/send/<template_type>", methods=['GET'])