Merge pull request #753 from alphagov/better-flash

Better flash messages for setting text message sender.

app/main/views/service_settings.py

@@ -272,7 +272,10 @@ def service_set_sms_sender(service_id):
     if request.method == 'GET':
         form.sms_sender.data = current_service.get('sms_sender')
     if form.validate_on_submit():
-        message = 'SMS Sender set to {}'.format(form.sms_sender.data)
+        if form.sms_sender.data:
+            message = 'Text message sender set to {}'.format(form.sms_sender.data)
+        else:
+            message = 'Text message sender removed'
         service_api_client.update_service(
             current_service['id'],
             current_service['name'],

tests/app/main/views/test_service_settings.py

@@ -735,3 +735,31 @@ def test_if_sms_sender_set_then_form_populated(app_,
         assert response.status_code == 200
         page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
         assert page.find(id='sms_sender')['value'] == 'elevenchars'
+
+
+@pytest.mark.parametrize("sender, expected_flash_message", [
+    ("elevenchars", 'Text message sender set to elevenchars'),
+    ('', 'Text message sender removed')
+])
+def test_set_text_message_sender_flash_messages(
+        app_,
+        active_user_with_permissions,
+        mocker,
+        mock_update_service,
+        service_one,
+        sender,
+        expected_flash_message):
+    with app_.test_request_context():
+        with app_.test_client() as client:
+            client.login(active_user_with_permissions, mocker, service_one)
+            data = {"sms_sender": sender}
+            response = client.post(url_for('main.service_set_sms_sender', service_id=service_one['id']),
+                                   data=data,
+                                   follow_redirects=True)
+
+            assert response.status_code == 200
+
+            page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
+            element = page.find('div', {"class": "banner-default-with-tick"})
+
+            assert element.text.strip() == expected_flash_message