darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-17 21:20:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add tests that user folder permission check is being called

Browse Source
This commit is contained in:
Alexey Bezhan
2019-03-22 17:33:47 +00:00
parent 355927d091
commit 364ed7d4c6
1 changed files with 69 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
tests/app/main/views/test_template_folders.py
View File

@@ -1,7 +1,7 @@
import uuid
import pytest
from flask import url_for
from flask import abort, url_for
from notifications_python_client.errors import HTTPError
from tests.conftest import (
@@ -499,6 +499,74 @@ def test_get_manage_folder_page_no_permissions(
)
@pytest.mark.parametrize('endpoint', [
'main.manage_template_folder',
'main.delete_template_folder',
])
def test_user_access_denied_to_template_folder_actions_without_folder_permission(
client_request,
active_user_with_permissions,
service_one,
mock_get_template_folders,
mocker,
endpoint
):
service_one['permissions'] += ['edit_folder_permissions']
mock = mocker.patch(
'app.models.service.Service.get_template_folder_with_user_permission_or_403',
side_effect=lambda *args: abort(403)
)
folder_id = str(uuid.uuid4())
client_request.get(
endpoint,
service_id=service_one['id'],
template_folder_id=folder_id,
_expected_status=403,
_test_page_title=False,
)
mock.assert_called_once_with(folder_id, active_user_with_permissions)
@pytest.mark.parametrize('endpoint', [
'main.check_notification',
'main.confirm_redact_template',
'main.delete_service_template',
'main.edit_service_template',
'main.edit_template_postage',
'main.send_messages',
'main.send_one_off',
'main.set_sender',
'main.set_template_sender',
])
def test_user_access_denied_to_template_actions_without_folder_permission(
client_request,
active_user_with_permissions,
service_one,
mocker,
endpoint
):
service_one['permissions'] += ['edit_folder_permissions']
mock = mocker.patch(
'app.models.service.Service.get_template_with_user_permission_or_403',
side_effect=lambda *args: abort(403)
)
template_id = str(uuid.uuid4())
client_request.get(
endpoint,
service_id=service_one['id'],
template_id=template_id,
_expected_status=403,
_test_page_title=False,
)
mock.assert_called_once_with(template_id, active_user_with_permissions)
def test_rename_folder(client_request, active_user_with_permissions, service_one, mock_get_template_folders, mocker):
mock_update = mocker.patch('app.template_folder_api_client.update_template_folder')
folder_id = str(uuid.uuid4())