darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 10:28:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use 301 to redirect old URL

Browse Source 
301 is a `permanent redirect`, which is semantically more accurate.
This commit is contained in:
Chris Hill-Scott
2019-01-30 13:36:01 +00:00
parent 3b15b04fc2
commit 2fae31a1ee
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/main/views/service_settings.py
+5 -2
View File
@@ -532,11 +532,14 @@ def service_set_inbound_sms(service_id):
@login_required @login_required
@user_has_permissions('manage_service') @user_has_permissions('manage_service')
def service_set_letters(service_id): def service_set_letters(service_id):
return redirect(url_for( return redirect(
url_for(
'.service_set_channel', '.service_set_channel',
service_id=current_service.id, service_id=current_service.id,
channel='letter', channel='letter',
)) ),
code=301,
)
@main.route("/services/<service_id>/service-settings/set-<channel>", methods=['GET', 'POST']) @main.route("/services/<service_id>/service-settings/set-<channel>", methods=['GET', 'POST'])
tests/app/main/views/test_service_settings.py
+1 -1
View File
@@ -2548,7 +2548,7 @@ def test_old_set_letters_page_redirects(
client_request.get( client_request.get(
'main.service_set_letters', 'main.service_set_letters',
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,
_expected_status=302, _expected_status=301,
_expected_redirect=url_for( _expected_redirect=url_for(
'main.service_set_channel', 'main.service_set_channel',
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,