Use 301 to redirect old URL

301 is a `permanent redirect`, which is semantically more accurate.

app/main/views/service_settings.py

@@ -532,11 +532,14 @@ def service_set_inbound_sms(service_id):
 @login_required
 @user_has_permissions('manage_service')
 def service_set_letters(service_id):
-    return redirect(url_for(
-        '.service_set_channel',
-        service_id=current_service.id,
-        channel='letter',
-    ))
+    return redirect(
+        url_for(
+            '.service_set_channel',
+            service_id=current_service.id,
+            channel='letter',
+        ),
+        code=301,
+    )
 
 
 @main.route("/services/<service_id>/service-settings/set-<channel>", methods=['GET', 'POST'])

tests/app/main/views/test_service_settings.py

@@ -2548,7 +2548,7 @@ def test_old_set_letters_page_redirects(
     client_request.get(
         'main.service_set_letters',
         service_id=SERVICE_ONE_ID,
-        _expected_status=302,
+        _expected_status=301,
         _expected_redirect=url_for(
             'main.service_set_channel',
             service_id=SERVICE_ONE_ID,