Merge pull request #1964 from GSA/notify-admin-1956

make sure phone number is always last in the one-off csv
This commit is contained in:
Carlo Costino
2024-09-30 13:03:09 -04:00
committed by GitHub

View File

@@ -1009,9 +1009,16 @@ def _send_notification(service_id, template_id):
keys = []
values = []
# Guarantee that the real phone number comes last, because some
# users will have placeholders like "add your second phone number"
# or something like as custom placeholders.
for k, v in session["placeholders"].items():
keys.append(k)
values.append(v)
if k != "phone number":
keys.append(k)
values.append(v)
if "phone number" in session["placeholders"].keys():
keys.append("phone number")
values.append(session["placeholders"]["phone number"])
data = ",".join(keys)
vals = ",".join(values)