test updates for no-email template creation

This commit is contained in:
stvnrlly
2022-12-02 14:04:54 -05:00
parent 5063ded045
commit 244c524809
3 changed files with 6 additions and 45 deletions

View File

@@ -50,41 +50,3 @@ def test_letters_lets_in_without_permission(
client_request.get_url(url(service_id=service_one['id']))
assert api_user_active['permissions'] == {}
@pytest.mark.parametrize('permissions, choices', [
(
['email', 'sms'],
['Email', 'Text message', 'Copy an existing template']
),
(
['email', 'sms'],
['Email', 'Text message', 'Copy an existing template']
),
])
def test_given_option_to_add_letters_if_allowed(
client_request,
service_one,
mocker,
mock_get_service_templates,
mock_get_template_folders,
mock_get_organisations_and_services_for_user,
mock_get_api_keys,
permissions,
choices,
):
service_one['permissions'] = permissions
page = client_request.get('main.choose_template', service_id=service_one['id'])
radios = page.select('#add_new_template_form input[type=radio]')
labels = page.select('#add_new_template_form label')
assert len(radios) == len(choices)
assert len(labels) == len(choices)
for index, choice in enumerate(permissions):
assert radios[index]['value'] == choice
for index, label in enumerate(choices):
assert labels[index].text.strip() == label

View File

@@ -1402,9 +1402,8 @@ def test_no_action_if_user_fills_in_ambiguous_fields(
assert page.select_one('button[value={}]'.format(data['operation']))
assert [
'email',
# 'email',
'sms',
# 'letter',
'copy-existing',
] == [
radio['value']

View File

@@ -96,7 +96,7 @@ def test_should_show_add_template_form_if_service_has_folder_permission(
assert [
(item['name'], item['value']) for item in page.select('[type=radio]')
] == [
('add_template_by_template_type', 'email'),
# ('add_template_by_template_type', 'email'),
('add_template_by_template_type', 'sms'),
]
assert not page.select('main a')
@@ -319,21 +319,21 @@ def test_should_show_live_search_if_service_has_lots_of_folders(
@pytest.mark.parametrize('service_permissions, expected_values, expected_labels', (
pytest.param(['email', 'sms'], [
'email',
# 'email',
'sms',
'copy-existing',
], [
'Email',
# 'Email',
'Text message',
'Copy an existing template',
]),
pytest.param(['email', 'sms'], [
'email',
# 'email',
'sms',
# 'letter',
'copy-existing',
], [
'Email',
# 'Email',
'Text message',
# 'Letter',
'Copy an existing template',