darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 06:38:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant 'filter' and return value

Browse Source 
'None' is the implicit return value. Since the filter was operating
on a yield that never yield 'None', it was redundant.
This commit is contained in:
Ben Thorner
2021-08-23 16:35:38 +01:00
parent a50b77d52c
commit 1923c5edb1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/broadcast_areas/models.py
View File

@@ -125,7 +125,7 @@ class BroadcastArea(BaseBroadcastArea, SortableMixin):
@cached_property @cached_property
def parents(self): def parents(self):
return list(filter(None, self._parents_iterator)) return list(self._parents_iterator)
@property @property
def _parents_iterator(self): def _parents_iterator(self):
@@ -135,7 +135,7 @@ class BroadcastArea(BaseBroadcastArea, SortableMixin):
parent = BroadcastAreasRepository().get_parent_for_area(id) parent = BroadcastAreasRepository().get_parent_for_area(id)
if not parent: if not parent:
return None return
parent_broadcast_area = BroadcastArea(parent) parent_broadcast_area = BroadcastArea(parent)