From 1923c5edb1cb859c3376dfb293ec1bf70b1c8871 Mon Sep 17 00:00:00 2001 From: Ben Thorner Date: Mon, 23 Aug 2021 16:35:38 +0100 Subject: [PATCH] Remove redundant 'filter' and return value 'None' is the implicit return value. Since the filter was operating on a yield that never yield 'None', it was redundant. --- app/broadcast_areas/models.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/broadcast_areas/models.py b/app/broadcast_areas/models.py index b33ee1ee4..6e8785b61 100644 --- a/app/broadcast_areas/models.py +++ b/app/broadcast_areas/models.py @@ -125,7 +125,7 @@ class BroadcastArea(BaseBroadcastArea, SortableMixin): @cached_property def parents(self): - return list(filter(None, self._parents_iterator)) + return list(self._parents_iterator) @property def _parents_iterator(self): @@ -135,7 +135,7 @@ class BroadcastArea(BaseBroadcastArea, SortableMixin): parent = BroadcastAreasRepository().get_parent_for_area(id) if not parent: - return None + return parent_broadcast_area = BroadcastArea(parent)