darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 00:43:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update error messages for letters that are too long

Browse Source 
To specify the number of sheets as well as pages in case this is not
clear.
This commit is contained in:
Katie Smith
2020-04-09 11:03:07 +01:00
parent 2992aacd8a
commit 13650b7d4b
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/partials/check/letter-too-long.html
View File

@@ -2,7 +2,7 @@
Your letter is too long Your letter is too long
</h1> </h1>
<p> <p>
Letters must be {{ letter_max_pages }} pages or less. Letters must be {{ letter_max_pages }} pages or less ({{ letter_max_pages // 2 }} double-sided sheets of paper).
<br> <br>
Your letter is {{ page_count }} pages long. Your letter is {{ page_count }} pages long.
</p> </p>

2
app/templates/views/guidance/upload-a-letter.html
View File

@@ -29,7 +29,7 @@
<ul class="list list-bullet"> <ul class="list list-bullet">
<li>a PDF</li> <li>a PDF</li>
<li>A4 portrait size (210 × 297 mm)</li> <li>A4 portrait size (210 × 297 mm)</li>
<li>10 pages or less</li> <li>10 pages or less (5 double-sided sheets of paper)</li>
<li>smaller than 2MB</li> <li>smaller than 2MB</li>
</ul> </ul>

2
app/templates/views/uploads/choose-file.html
View File

@@ -44,7 +44,7 @@
<ul class="list list-bullet"> <ul class="list list-bullet">
<li>a PDF</li> <li>a PDF</li>
<li>A4 portrait size (210 × 297 mm)</li> <li>A4 portrait size (210 × 297 mm)</li>
<li>10 pages or less</li> <li>10 pages or less (5 double-sided sheets of paper)</li>
<li>smaller than 2MB</li> <li>smaller than 2MB</li>
</ul> </ul>

4
app/utils.py
View File

@@ -612,12 +612,12 @@ LETTER_VALIDATION_MESSAGES = {
'letter-too-long': { 'letter-too-long': {
'title': 'Your letter is too long', 'title': 'Your letter is too long',
'detail': ( 'detail': (
'Letters must be 10 pages or less. <br>' 'Letters must be 10 pages or less (5 double-sided sheets of paper). <br>'
'Your letter is {page_count} pages long.' 'Your letter is {page_count} pages long.'
), ),
'summary': ( 'summary': (
'Validation failed because this letter is {page_count} pages long.<br>' 'Validation failed because this letter is {page_count} pages long.<br>'
'Letters must be 10 pages or less.' 'Letters must be 10 pages or less (5 double-sided sheets of paper).'
), ),
}, },
'no-encoded-string': { 'no-encoded-string': {

4
tests/app/test_utils.py
View File

@@ -462,12 +462,12 @@ def test_get_letter_validation_error_for_unknown_error():
None, None,
'Your letter is too long', 'Your letter is too long',
( (
'Letters must be 10 pages or less. ' 'Letters must be 10 pages or less (5 double-sided sheets of paper). '
'Your letter is 13 pages long.' 'Your letter is 13 pages long.'
), ),
( (
'Validation failed because this letter is 13 pages long.' 'Validation failed because this letter is 13 pages long.'
'Letters must be 10 pages or less.' 'Letters must be 10 pages or less (5 double-sided sheets of paper).'
), ),
), ),
( (