darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-31 20:00:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove notify_go_live_incomplete tag

Browse Source 
The new taxonomy doesn't have a `notify_go_live_incomplete` tag. We
replaced this with `notify_go_live_incomplete_mou` because the only way
users can submit an incomplete request is if they do not agree to the
MOU.

These are the incomplete tags:

- `notify_go_live_incomplete_mou`
- `notify_go_live_incomplete_reply_to`
- `notify_go_live_incomplete_shared_email`
- `notify_go_live_incomplete_templates`

Of those, only the first one is applied automatically.
This commit is contained in:
Chris Hill-Scott
2019-11-19 16:42:25 +00:00
parent 7a5d301104
commit 12b7c5d5e8
2 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/models/service.py
View File

@@ -625,7 +625,6 @@ class Service(JSONModel):
return
for test, tag in (
(True, ''),
(not self.volumes, '_volumes'),
(not self.go_live_checklist_completed, '_checklist'),
(not self.organisation.agreement_signed, '_mou'),

6
tests/app/main/views/test_service_settings.py
View File

@@ -1457,7 +1457,6 @@ def test_should_redirect_after_request_to_go_live(
tags=[
'notify_action',
'notify_go_live',
'notify_go_live_incomplete',
] + extra_tags + [
'notify_go_live_incomplete_checklist',
'notify_go_live_incomplete_mou',
@@ -1631,7 +1630,6 @@ def test_should_be_able_to_request_to_go_live_with_no_organisation(
[
'notify_action',
'notify_go_live',
'notify_go_live_incomplete',
'notify_go_live_incomplete_checklist',
'notify_go_live_incomplete_email_reply_to',
],
@@ -1667,7 +1665,6 @@ def test_should_be_able_to_request_to_go_live_with_no_organisation(
[
'notify_action',
'notify_go_live',
'notify_go_live_incomplete',
'notify_go_live_incomplete_checklist',
'notify_go_live_incomplete_sms_sender',
],
@@ -1686,7 +1683,6 @@ def test_should_be_able_to_request_to_go_live_with_no_organisation(
[
'notify_action',
'notify_go_live',
'notify_go_live_incomplete',
'notify_go_live_incomplete_checklist',
'notify_go_live_incomplete_team_member',
],
@@ -1705,7 +1701,6 @@ def test_should_be_able_to_request_to_go_live_with_no_organisation(
[
'notify_action',
'notify_go_live',
'notify_go_live_incomplete',
'notify_go_live_incomplete_checklist',
'notify_go_live_incomplete_template_content',
],
@@ -1724,7 +1719,6 @@ def test_should_be_able_to_request_to_go_live_with_no_organisation(
[
'notify_action',
'notify_go_live',
'notify_go_live_incomplete',
'notify_go_live_incomplete_volumes',
'notify_go_live_incomplete_checklist',
'notify_go_live_incomplete_mou',