darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-17 11:46:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #846 from GSA/822-restrict-international-message-service

Browse Source 
822 - restrict international message services
This commit is contained in:
Carlo Costino
2023-10-06 12:18:17 -04:00
committed by GitHub
parent 3a4e3889c0 afe6e9c11a
commit 124d342b39
2 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/templates/views/service-settings.html
View File

@@ -94,17 +94,19 @@
}}
{% endcall %}
{% call settings_row(if_has_permission='sms') %}
{{ text_field('Send international text messages') }}
{{ boolean_field('international_sms' in current_service.permissions) }}
{{ edit_field(
'Change',
url_for('.service_set_international_sms', service_id=current_service.id),
permissions=['manage_service'],
suffix='your settings for sending international text messages',
)
}}
{% endcall %}
{% if current_user.platform_admin %}
{% call settings_row(if_has_permission='sms') %}
{{ text_field('Send international text messages') }}
{{ boolean_field('international_sms' in current_service.permissions) }}
{{ edit_field(
'Change',
url_for('.service_set_international_sms', service_id=current_service.id),
permissions=['manage_service'],
suffix='your settings for sending international text messages',
)
}}
{% endcall %}
{% endif %}
<!-- {% call settings_row(if_has_permission='sms') %}
{{ text_field('Receive text messages') }}

3
tests/app/main/views/service_settings/test_service_settings.py
View File

@@ -60,7 +60,6 @@ def mock_get_service_settings_page_common(
"Send text messages On Change your settings for sending text messages",
"Start text messages with service name On Change your settings "
"for starting text messages with service name",
"Send international text messages Off Change your settings for sending international text messages",
],
),
(
@@ -235,7 +234,6 @@ def test_send_files_by_email_row_on_settings_page(
"Send text messages On Change your settings for sending text messages",
"Start text messages with service name On Change your settings "
"for starting text messages with service name",
"Send international text messages On Change your settings for sending international text messages",
],
),
(
@@ -246,7 +244,6 @@ def test_send_files_by_email_row_on_settings_page(
"Send text messages On Change your settings for sending text messages",
"Start text messages with service name On Change your settings "
"for starting text messages with service name",
"Send international text messages Off Change your settings for sending international text messages",
],
),
],