add vcap secret

.ds.baseline

@@ -133,7 +133,7 @@
         "filename": ".github/workflows/checks.yml",
         "hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8",
         "is_verified": false,
-        "line_number": 69,
+        "line_number": 67,
         "is_secret": false
       }
     ],
@@ -684,5 +684,5 @@
       }
     ]
   },
-  "generated_at": "2024-10-03T18:49:38Z"
+  "generated_at": "2024-10-04T14:50:29Z"
 }

.github/workflows/checks.yml

@@ -59,8 +59,6 @@ jobs:
       pull-requests: write
       contents: write
     runs-on: ubuntu-latest
-    env:
-      VCAP_SERVICES: $VCAP_SERVICES
     services:
       postgres:
         image: postgres
@@ -95,10 +93,6 @@ jobs:
       - name: Check API Server availability
         run: |
           curl --fail -v https://notify-api-staging.app.cloud.gov || exit 1
-      - name: Echo a secret
-        run: |
-          echo "HERE IS A SECRET:"
-          echo ${{ secrets.DANGEROUS_SALT }}
       - name: Run Admin server
         # If we want to log stuff and see what's broken,
         # insert this line:
@@ -119,7 +113,7 @@ jobs:
           NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
           NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}
           NOTIFY_E2E_TEST_URI: http://localhost:6012/
-          VCAP_SERVICES: $VCAP_SERVICES
+          VCAP_SERVICES: ${{ secrets.VCAP_SERVICES }}
 
   validate-new-relic-config:
     runs-on: ubuntu-latest