Merge pull request #2146 from alphagov/basic-view

Rename ‘caseworker’ to ‘basic view’

app/main/forms.py

@@ -303,8 +303,8 @@ class CaseworkingPermissionsForm(AbstractPermissionsForm):
     user_type = RadioField(
         'User type',
         choices=[
-            ('caseworker', 'Caseworker'),
-            ('admin', 'Admin'),
+            ('caseworker', 'Basic view'),
+            ('admin', 'Admin view'),
         ],
     )
 

app/templates/views/manage-users/permissions.html

@@ -3,7 +3,7 @@
 
 {% if 'caseworking' in current_service.permissions %}
   <div class="conditional-radios" data-module='conditional-radios'>
-    {% call radios_wrapper(form.user_type) %}
+    {% call radios_wrapper(form.user_type, hide_legend=True) %}
       {% for option in form.user_type %}
 
         <div class="bottom-gutter-1-3">

app/templates/views/service-settings.html

@@ -366,7 +366,7 @@
         </li>
         <li class="bottom-gutter">
           <a href="{{ url_for('.service_switch_caseworking', service_id=current_service.id) }}" class="button">
-            {{ 'Stop granting of caseworking permission' if 'caseworking' in current_service.permissions else 'Allow granting of caseworking permission' }}
+            {{ 'Stop basic view' if 'caseworking' in current_service.permissions else 'Allow basic view' }}
           </a>
         </li>
         <li class="bottom-gutter">

tests/app/main/views/service_settings/test_service_setting_permissions.py

@@ -45,9 +45,9 @@ def get_service_settings_page(
         '.service_switch_can_upload_document', {}, 'Allow to upload documents'),
 
     ({'permissions': []},
-        '.service_switch_caseworking', {}, 'Allow granting of caseworking permission'),
+        '.service_switch_caseworking', {}, 'Allow basic view'),
     ({'permissions': ['caseworking']},
-        '.service_switch_caseworking', {}, 'Stop granting of caseworking permission'),
+        '.service_switch_caseworking', {}, 'Stop basic view'),
 
     ({'permissions': ['sms']}, '.service_set_inbound_number', {'set_inbound_sms': True}, 'Allow inbound sms'),