darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-17 04:59:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix misleading class name

Browse Source 
Not sure where this came from, but visually our tables have always
aligned text to the left by default.
This commit is contained in:
Chris Hill-Scott
2019-04-29 16:21:47 +01:00
parent 5340c4c2e8
commit 0512f40ad3
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/stylesheets/components/table.scss
View File

@@ -69,7 +69,7 @@
}
td.table-field-center-aligned {
td.table-field-left-aligned {
&:first-child {

2
app/templates/components/table.html
View File

@@ -67,7 +67,7 @@
{% macro field(align='left', status='', border=True) -%}
{% set field_alignment = 'table-field-right-aligned' if align == 'right' else 'table-field-center-aligned' %}
{% set field_alignment = 'table-field-right-aligned' if align == 'right' else 'table-field-left-aligned' %}
{% set border = '' if border else 'table-field-noborder' %}
<td class="{{ [field_alignment, border]|join(' ') }}">

2
tests/app/main/views/test_dashboard.py
View File

@@ -569,7 +569,7 @@ def test_monthly_shows_letters_in_breakdown(
service_id=service_one['id']
)
columns = page.select('.table-field-center-aligned .big-number-label')
columns = page.select('.table-field-left-aligned .big-number-label')
assert normalize_spaces(columns[0].text) == 'emails'
assert normalize_spaces(columns[1].text) == 'text messages'

18
tests/app/main/views/test_send.py
View File

@@ -656,10 +656,10 @@ def test_upload_valid_csv_shows_preview_and_table(
for row_index, row in enumerate([
(
'<td class="table-field-center-aligned"> <div class=""> 07700900001 </div> </td>',
'<td class="table-field-center-aligned"> <div class=""> A </div> </td>',
'<td class="table-field-left-aligned"> <div class=""> 07700900001 </div> </td>',
'<td class="table-field-left-aligned"> <div class=""> A </div> </td>',
(
'<td class="table-field-center-aligned"> '
'<td class="table-field-left-aligned"> '
'<div class="table-field-status-default"> '
'<ul> '
'<li>foo</li> <li>foo</li> <li>foo</li> '
@@ -669,10 +669,10 @@ def test_upload_valid_csv_shows_preview_and_table(
)
),
(
'<td class="table-field-center-aligned"> <div class=""> 07700900002 </div> </td>',
'<td class="table-field-center-aligned"> <div class=""> B </div> </td>',
'<td class="table-field-left-aligned"> <div class=""> 07700900002 </div> </td>',
'<td class="table-field-left-aligned"> <div class=""> B </div> </td>',
(
'<td class="table-field-center-aligned"> '
'<td class="table-field-left-aligned"> '
'<div class="table-field-status-default"> '
'<ul> '
'<li>foo</li> <li>foo</li> <li>foo</li> '
@@ -682,10 +682,10 @@ def test_upload_valid_csv_shows_preview_and_table(
)
),
(
'<td class="table-field-center-aligned"> <div class=""> 07700900003 </div> </td>',
'<td class="table-field-center-aligned"> <div class=""> C </div> </td>',
'<td class="table-field-left-aligned"> <div class=""> 07700900003 </div> </td>',
'<td class="table-field-left-aligned"> <div class=""> C </div> </td>',
(
'<td class="table-field-center-aligned"> '
'<td class="table-field-left-aligned"> '
'<div class="table-field-status-default"> '
'<ul> '
'<li>foo</li> <li>foo</li> '